-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust scroll container height to make it a proper boundary element for actions #22999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as it should. I couldn't find any side effects. 👍
@@ -1443,6 +1443,8 @@ doesnotexist:-o-prefocus, .strengthify-wrapper { | |||
$grid-row-height: 60px; | |||
$grid-col-min-width: 160px; | |||
overflow-x: scroll; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a side note: Why is this overflow-x: scroll
here? On my setup, it only creates an empty x-scrollbar, but I can't figure out what needs explicit x-scrolling in settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…or actions Signed-off-by: Julius Härtl <jus@bitgrid.net>
3ab36f1
to
92ab659
Compare
rebased then lets get it in |
/backport to stable20 |
More general approach to replace #22998
Before:
See no menu (since it has boundaries to the body element which is out of the visible area)
After:
See the menu
See nextcloud-libraries/nextcloud-vue#1384 for the background of this issue.