-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only run the background scanner for users that have unscanned files #23004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
added a commit
that referenced
this pull request
Sep 22, 2020
improves performance of #23004 Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
approved these changes
Sep 22, 2020
icewind1991
force-pushed
the
files-scan-background
branch
2 times, most recently
from
September 22, 2020 14:09
02d71c9
to
20c4920
Compare
CI says no |
icewind1991
force-pushed
the
files-scan-background
branch
from
September 24, 2020 12:00
20c4920
to
2ab53e0
Compare
redone the tests |
ping @nickvergessen |
nickvergessen
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
icewind1991
force-pushed
the
files-scan-background
branch
from
October 14, 2020 14:05
9f913f4
to
4cfd165
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34138: failureacceptance-header
Show full log
|
instead of looping trough all users and seeing if they have unscanned files, we do a single query to find all storages that need scanning and run trough the users for them Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
files-scan-background
branch
from
October 20, 2020 15:48
4cfd165
to
d523286
Compare
juliushaertl
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of looping trough all users and seeing if they have unscanned files, we do a single query to find all storages that need scanning and run trough the users for them
Signed-off-by: Robin Appelman robin@icewind.nl