Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only run the background scanner for users that have unscanned files #23004

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

icewind1991
Copy link
Member

instead of looping trough all users and seeing if they have unscanned files, we do a single query to find all storages that need scanning and run trough the users for them

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 22, 2020
@icewind1991 icewind1991 added this to the Nextcloud 21 milestone Sep 22, 2020
icewind1991 added a commit that referenced this pull request Sep 22, 2020
improves performance of #23004

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the files-scan-background branch 2 times, most recently from 02d71c9 to 20c4920 Compare September 22, 2020 14:09
@rullzer
Copy link
Member

rullzer commented Sep 22, 2020

CI says no

@icewind1991
Copy link
Member Author

redone the tests

@rullzer
Copy link
Member

rullzer commented Oct 3, 2020

ping @nickvergessen

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@faily-bot
Copy link

faily-bot bot commented Oct 14, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34138: failure

acceptance-header

  • tests/acceptance/features/header.feature:44
Show full log
  Scenario: just added users are seen in the contacts menu               # /drone/src/tests/acceptance/features/header.feature:44
    Given I am logged in as the admin                                    # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                         # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                      # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                            # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user user1 with password 123456acb                      # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user user1             # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    When I open the Contacts menu                                        # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                           # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "user1" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

instead of looping trough all users and seeing if they have unscanned files, we do a single query to find all storages that need scanning and run trough the users for them

Signed-off-by: Robin Appelman <robin@icewind.nl>
@juliushaertl juliushaertl merged commit 88eebf9 into master Nov 5, 2020
@juliushaertl juliushaertl deleted the files-scan-background branch November 5, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants