Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity notifications for groupmates by Comments (when using Group Folder app) #23036

Closed
wants to merge 1 commit into from
Closed

Activity notifications for groupmates by Comments (when using Group Folder app) #23036

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 24, 2020 •
edited by ghost
Loading

Currently:
Comments on files in group folders does not generate activity notifications for the groupmates.

With this PR:
Also include groupmates to receive the notifications.

@ghost ghost force-pushed the update/comment_notifications_for_group_folders branch from 1803c5f to d156170 Compare September 24, 2020 13:58
@ghost
Copy link
Author

ghost commented Sep 24, 2020

Hi @nickvergessen and @ChristophWurst ! Pls, when you have time, could you make the review on this PR? Thanks a lot in advance!!

@ghost ghost changed the title Activity notifications for groupmaters by Comments (when using Group Folder app) Activity notifications for groupmates by Comments (when using Group Folder app) Sep 24, 2020
@ghost ghost mentioned this pull request Oct 2, 2020
Open
@rullzer rullzer added 3. to review Waiting for reviews enhancement labels Oct 4, 2020
@nickvergessen nickvergessen added this to the Nextcloud 21 milestone Oct 12, 2020
@nickvergessen
Copy link
Member

/backport to stable20

ChristophWurst
ChristophWurst approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@nickvergessen
Copy link
Member

@chrisfritsche can you rebase one last time?

This was referenced Dec 14, 2020
Merged
Merged
This was referenced Dec 28, 2020
Merged
Merged
@MorrisJobke
update Comment Listener
3a16939 
Signed-off-by: Chris Fritsche <chris.fritsche@cunio.de>
@MorrisJobke MorrisJobke force-pushed the update/comment_notifications_for_group_folders branch from d156170 to 3a16939 Compare January 7, 2021 20:49
@MorrisJobke
Copy link
Member

@chrisfritsche can you rebase one last time?

I rebased.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2021
@rullzer
Copy link
Member

rullzer commented Jan 8, 2021

CI is not happy

@rullzer rullzer removed the 4. to release Ready to be released and/or waiting for tests to finish label Jan 8, 2021
@skjnldsv skjnldsv modified the milestones: Nextcloud 22, Nextcloud 23 Jun 2, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Merged
@skjnldsv
Copy link
Member

/rebase

@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
This was referenced Apr 7, 2022
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz removed this from the Nextcloud 26 milestone Mar 7, 2023
@blizzz
Copy link
Member

blizzz commented Mar 7, 2023

Closing for inactivity.

@blizzz blizzz closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
2. developing Work in progress enhancement feature: activity and notification feature: comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nickvergessen @MorrisJobke @rullzer @PVince81 @J0WI @juliushaertl @blizzz @skjnldsv @ChristophWurst