Loop for newest version in appstore response #2307
Conversation
The current implementation when fetching apps from the appstore is to assume that the first element is the newest version, this is now always applicable and leads to the fact that for some apps (e.g. nextant) the newest version is not delivered. This can be easily tested by comparing the version of the downloaded Nextant version. This change will loop over all releases delivered by the appstore and chooses the newest compatible one. While not the cleanest solution, it does its job. Most of the code are actually unit tests. Whereas I have copied the whole original response from the appstore and also have performed the transformation. So that's why the diff looks so huge. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
Works, afterwards i am suggested an update to 0.10.0 on the category page, normal enabled page however does not. |
The enabled page doesn't pass through "getAppsForCategory" thus it also needs to have that special logic applied. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Good point. Adjusted the logic to also cover that. This controller file is really a little bit … special … |
|
Works now 👍 |
Current coverage is 57.04% (diff: 100%)@@ master #2307 diff @@
==========================================
Files 1190 1190
Lines 71672 71717 +45
Methods 7292 7296 +4
Messages 0 0
Branches 1213 1213
==========================================
+ Hits 40873 40912 +39
- Misses 30799 30805 +6
Partials 0 0
|
|
Code looks OK, works 👍 |
|
Hm, this does not filter pre-releases, is this what you want? Users will be prompted to upgrade to 2.0.0-beta.1 for instance |
https://github.com/nextcloud/server/pull/2307/files#diff-83840d74b03720feef2006e83453333eR83 should remove all nightlies. Am I missing something? |
| // Exclude all nightly releases | ||
| if($release['isNightly'] === false) { | ||
| // Exclude all versions not compatible with the current version | ||
| $versionParser = new VersionParser(); |
There was a problem hiding this comment.
This should not be needed. All apps fetched from the API are working on the version provided in your URL
|
@LukasReschke right, however there are 3 "channels":
|
|
So for what does one have to filter? The docs doesn't tell anything about pre-releases etc… (also it seems rather unnecessary for me at the moment since Nextcloud only supports the stable channel at the moment, but fair enough…) |
|
Pre-releases in semver are denoted by having a - after the version string. Since we don't allow build metadata in our version you can simply check with if (strpos($release['version'], '-') === false) {
// not a pre-release
} |
|
Versioning is documented at http://nextcloudappstore.readthedocs.io/en/latest/restapi.html#get-all-apps-and-releases version If you think this was not enough docs to handle this case, can you create a pull request to the docs that specifically adds a short description about pre-releases :D? |
As SemVer can be used apps could define a release like "10.0.0-alpha". This is something that we don't support at the moment in the server and we should filter all prereleases. Ref #2307 (comment) Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
|
@BernhardPosselt Ever heard of -PL releases? just saying |
|
#2327 should make you all happier… I hope… |
|
@nickvergessen nope, havent heard of that one |
The current implementation when fetching apps from the appstore is to assume that the first element is the newest version, this is now always applicable (e.g. daily builds etc.) and leads to the fact that for some apps (e.g. nextant) the newest version is not delivered. This can be easily tested by comparing the version of the downloaded Nextant version, without this patch it only delivers 0.6.6 instead of 0.10.0. (Category: Files)
This change will loop over all releases delivered by the appstore and chooses the newest compatible one. While not the cleanest solution, it does its job.
Most of the code are actually unit tests. Whereas I have copied the whole original response from the appstore and also have performed the transformation. So that's why the diff looks so huge.
Signed-off-by: Lukas Reschke lukas@statuscode.ch