Exclude pre-release versions as per SemVer #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As SemVer can be used apps could define a release like "10.0.0-alpha". This is something that we don't support at the moment in the server and we should filter all prereleases. Ref #2307 (comment) Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
MorrisJobke
reviewed
Nov 25, 2016
| foreach($app['releases'] as $release) { | ||
| // Exclude all nightly releases | ||
| if($release['isNightly'] === false) { | ||
| // Exclude all nightly and pre-releases |
Member
There was a problem hiding this comment.
Pre-releases are defined as "contains a dash"?
Member
There was a problem hiding this comment.
Yes, check the semver spec :)
If you disallow the build metadata there's basically only versions like 1.0.0 and pre-releases like 1.0.0-alpha
Member
|
👍 |
1 similar comment
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As SemVer can be used apps could define a release like "10.0.0-alpha". This is something that we don't support at the moment in the server and we should filter all prereleases.
Ref #2307 (comment)
Signed-off-by: Lukas Reschke lukas@statuscode.ch
@BernhardPosselt That should make you happier 😉