expand 'path is already shared' error message #23718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
reviewed
Oct 27, 2020
|
Also CI fails due to the changed message. |
icewind1991
force-pushed
the
already-shared-error-message
branch
2 times, most recently
from
a18de89
to
b254385
Compare
MorrisJobke
reviewed
Oct 29, 2020
lib/private/Share20/Manager.php
Outdated
| @@ -563,9 +564,9 @@ protected function userCreateChecks(IShare $share) { | |||
| //Shares are not identical | |||
| } | |||
|
|
|||
| // Identical share already existst | |||
| // Identical share already exist | |||
There was a problem hiding this comment.
Suggested change
| // Identical share already exist | |
| // Identical share already exists |
MorrisJobke
reviewed
Oct 29, 2020
MorrisJobke
reviewed
Oct 29, 2020
|
Conflicts with #25533 |
MorrisJobke
reviewed
Mar 15, 2021
| use OC\HintException; | ||
| use OCP\IL10N; | ||
|
|
||
| class AlreadyShared extends HintException { |
There was a problem hiding this comment.
Let me drop this commit, as it was already implemented in #25533
MorrisJobke
force-pushed
the
already-shared-error-message
branch
2 times, most recently
from
39f849a
to
6213473
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
force-pushed
the
already-shared-error-message
branch
from
6213473
to
a550649
Compare
MorrisJobke
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
I rebased it and used the changes from #25533 in here instead of reimplementing it 👍
|
/backport to stable20 |
|
/backport to stable21 |
rullzer
approved these changes
Mar 19, 2021
This was referenced Mar 19, 2021
|
Noooooooooo |
No? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman robin@icewind.nl