-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: php output_buffering setup check allowed values #23824
fix: php output_buffering setup check allowed values #23824
Conversation
Signed-off-by: Moritz Stückler <moritz.stueckler@gmail.com>
Thanks 👍 How do you set the value to
|
Not sure how it works via the CLI. In my case I just edited the |
According to the PHP source it can be either |
Signed-off-by: Moritz Stückler <moritz.stueckler@gmail.com>
Do you encounter this problem?
Taken from the
Just to mention it: |
@kesselb Yes, I did have this problem. However, you are right that As you suggested, I fixed my problem by using In both cases ( |
That's the reason it always worked with CLI ;) I'm not sure what to do now. If output_buffering = "Off" turns the output buffering off the check should also accept the value. Mind to reopen or create a new PR? Please limit the values to https://github.com/php/php-src/blob/bcdb54d47694cd9767e7f2772d6d061e03ba316f/php.ini-production#L55-L56. true, no or false (=> lowercase) should not work. |
I found some time to have a second look at it. On my development setup the current approach seems correct.
A value like |
Both
Off
andoff
are valid values for a PHP configuration. Therefore, the Nextcloud setup check should also accept these values. Otherwise, Nextcloud will falsely report a wrong/missing PHP config directive.See also nextcloud/documentation#478