Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP: fix inGroup for memberUid type of group memberships #24402

Merged
merged 6 commits into from
Dec 15, 2020
Merged

LDAP: fix inGroup for memberUid type of group memberships #24402

merged 6 commits into from
Dec 15, 2020

Commits on Nov 26, 2020

  1. flatten result array as expected by following code 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    57bfe0d View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. moved the array_reduce to fix large search case 

    also added some additional comments and renamed some vars to make it intuitive whats in them

Signed-off-by: Tobias Perschon <tobias@perschon.at>
    @tofuSCHNITZEL
    tofuSCHNITZEL committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    594370e View commit details
    Browse the repository at this point in the history

  2. use faster and less hungry foreach 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    1f40ecc View commit details
    Browse the repository at this point in the history

  3. check number of members after potential resolving of rdns 

    - the type check is not necessary anymore for the return type of
  _groupMembers()

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    2709128 View commit details
    Browse the repository at this point in the history

  4. add unit tests 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    e9e61b9 View commit details
    Browse the repository at this point in the history

  5. php-cs happyness 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    af6b0ec View commit details
    Browse the repository at this point in the history