Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont offer to edit external config settings if we can't edit them #24661

Merged
merged 2 commits into from
Jan 11, 2021
Merged

dont offer to edit external config settings if we can't edit them #24661

merged 2 commits into from
Jan 11, 2021

Conversation

icewind1991
Copy link
Member

no need to confuse the user by providing options that he cant use.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Dec 11, 2020
@icewind1991 icewind1991 added this to the Nextcloud 21 milestone Dec 11, 2020
This was referenced Dec 14, 2020
Merged
Merged
@rullzer rullzer mentioned this pull request Dec 28, 2020
Merged
39 tasks
@juliushaertl
Copy link
Member

Rebased and pushed a fix for the tests

@rullzer rullzer mentioned this pull request Jan 4, 2021
Merged
5 tasks
@MorrisJobke
Copy link
Member

CI fails.

@icewind1991
dont offer to edit external config settings if we can't edit them
518e91b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
adjust tests
79b142c 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@nextcloud nextcloud deleted a comment from faily-bot bot Jan 8, 2021
@icewind1991
Copy link
Member Author

CI is happy (except for our scheduled mysql test timeout)

@rullzer rullzer mentioned this pull request Jan 11, 2021
Merged
14 tasks
@MorrisJobke MorrisJobke merged commit 82ee304 into master Jan 11, 2021
@MorrisJobke MorrisJobke deleted the external-storage-cant-edit branch January 11, 2021 09:42
@icewind1991
Copy link
Member Author

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@icewind1991 @juliushaertl @MorrisJobke @rullzer