Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable20] dont offer to edit external config settings if we can't edit them #25132

Merged
merged 4 commits into from
Feb 18, 2021
Merged

[stable20] dont offer to edit external config settings if we can't edit them #25132

merged 4 commits into from
Feb 18, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #24661

@icewind1991 @backportbot
dont offer to edit external config settings if we can't edit them
e0d85ed 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @backportbot
adjust tests
6404627 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.5 milestone Jan 14, 2021
@rullzer rullzer mentioned this pull request Jan 19, 2021
Merged
MorrisJobke
MorrisJobke requested changes Jan 19, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Let's wait for 20.0.7 to be out

@rullzer rullzer mentioned this pull request Jan 28, 2021
Merged
rullzer
rullzer requested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI says no...
@icewind1991 please check

@rullzer rullzer mentioned this pull request Feb 5, 2021
Merged
@rullzer rullzer mentioned this pull request Feb 16, 2021
Merged
icewind1991 and others added 2 commits February 18, 2021 15:55
@icewind1991 @MorrisJobke
Update apps/files_external/js/statusmanager.js
590ef22 
Co-authored-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix test
e7805e5 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member

CI is happy

@rullzer rullzer merged commit b986c9e into stable20 Feb 18, 2021
@rullzer rullzer deleted the backport/24661/stable20 branch February 18, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 20.0.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icewind1991 @rullzer @MorrisJobke