Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for webp #25173

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add support for webp #25173

merged 1 commit into from
Jan 19, 2021

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jan 17, 2021

Including handling in OC_Image
But also a preview provider

Of course only works if your php actually supports webp

Most useful feature of the release as it allow sharing webp memes and getting a proper preview for it.

@rullzer rullzer changed the title Add support for webp\ Add support for webp Jan 18, 2021
@juliushaertl
Copy link
Member

Psalm is not happy:

/home/runner/work/server/server/lib/private/PreviewManager.php:317:4:error - UndefinedClass: Class or interface OC\Preview\WebP does not exist
/home/runner/work/server/server/lib/private/PreviewManager.php:364:31:error - UndefinedClass: Class or interface OC\Preview\WebP does not exist
/home/runner/work/server/server/lib/private/legacy/OC_Image.php:645:120:error - InvalidScalarArgument: Argument 1 of OC\Files

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great if you actually added the webp class to git :)

@rullzer
Copy link
Member Author

rullzer commented Jan 18, 2021

would be great if you actually added the webp class to git :)

mimimi

@rullzer rullzer modified the milestones: Nextcloud 22, Nextcloud 21 Jan 19, 2021
Including handling in OC_Image
But also a preview provider

Of course only works if your php actually supports webp

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@faily-bot
Copy link

faily-bot bot commented Jan 19, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1494: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@rullzer rullzer merged commit 3658d83 into master Jan 19, 2021
@rullzer rullzer deleted the enh/webp_support branch January 19, 2021 20:01
@rullzer rullzer mentioned this pull request Jan 21, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants