Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix db selection design and fix #2511 #2524

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Fix db selection design and fix #2511 #2524

merged 1 commit into from
Dec 6, 2016

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 6, 2016

@skjnldsv
Fix db selection design and fix #2511
0abcba2 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Dec 6, 2016
@skjnldsv skjnldsv added this to the Nextcloud 11.0 milestone Dec 6, 2016
@mention-bot
Copy link

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @butonic and @Henni to be potential reviewers.

@MorrisJobke
Copy link
Member

  • Sadly now the LDAP wizard is a bit broken (Just enable the app and go to the admin settings - you don't need an LDAP server):

Hovering the button there:

bildschirmfoto 2016-12-06 um 10 17 05
bildschirmfoto 2016-12-06 um 10 17 08

@MorrisJobke
Copy link
Member

Sadly now the LDAP wizard is a bit broken (Just enable the app and go to the admin settings - you don't need an LDAP server):

Discussed on IRC: will get addressed in a separate PR, because it's also broken on master.

@MorrisJobke
Copy link
Member

👍 from me for this

@rullzer
Copy link
Member

rullzer commented Dec 6, 2016

LGTM

@rullzer rullzer merged commit b190153 into master Dec 6, 2016
@rullzer rullzer deleted the fix-db-selection branch December 6, 2016 11:02
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 6, 2016

Thanks @rullzer 😍

@MorrisJobke MorrisJobke mentioned this pull request Dec 6, 2016
Closed
@skjnldsv skjnldsv mentioned this pull request Dec 6, 2016
Closed
@jancborchardt
Copy link
Member

Dude @skjnldsv thank you :) You’ve been fixing the hell out of all these design issues the last days! 🤘

@violethaze74 violethaze74 mentioned this pull request Aug 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@skjnldsv @mention-bot @MorrisJobke @rullzer @jancborchardt