Make user list pagination more tolerant #25443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
requested review from
rullzer,
nickvergessen,
ChristophWurst and
juliushaertl
|
/backport to stable20 |
|
/backport to stable21 |
ChristophWurst
approved these changes
Feb 3, 2021
|
@PVince81 rebase |
|
I'll solve this |
In case the server returns more results than expected by the limit, it is now still interpreted as there being more results to query. This situation can happen when there are multiple user backends in place. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
bugfix/25442/fix-settings-users-pagination-tolerance
branch
from
62cd1ee
to
49568e2
Compare
rullzer
deleted the
bugfix/25442/fix-settings-users-pagination-tolerance
branch
This was referenced Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the server returns more results than expected by the limit, it
is now still interpreted as there being more results to query.
This situation can happen when there are multiple user backends in
place.
Fixes #25442