Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid template creators being registered multiple times #25446

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

juliushaertl
Copy link
Member

This seems to happen on our cloud instance for some reason though I cannot really reproduce it locally it should fix the issue where a registered file create action would be displayed multiple times.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug 3. to review Waiting for reviews labels Feb 2, 2021
@juliushaertl juliushaertl added this to the Nextcloud 21 milestone Feb 2, 2021
@faily-bot
Copy link

faily-bot bot commented Feb 2, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1869: failure

object-store-azure

memcache-memcached

Show full log
 phpenmod xdebug
WARNING: Module xdebug ini file doesn't exist under /etc/php/7.3/mods-available
+ service memcached restart
Restarting memcached: memcached.
+ ./autotest.sh sqlite tests/lib/Memcache/MemcachedTest.php
Using PHP executable /usr/bin/php
Using database oc_autotest
Setup environment for sqlite testing on local storage ...
Installing ....
Nextcloud was successfully installed
Testing with sqlite ...
/usr/local/bin/phpunit --configuration phpunit-autotest.xml --coverage-clover autotest-clover-sqlite.xml --coverage-html coverage-html-sqlite --log-junit autotest-results-sqlite.xml ../tests/lib/Memcache/MemcachedTest.php 
PHPUnit 8.4.3 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.3.11-1+0~20191026.48+debian8~1.gbpf71ca0
Configuration: /drone/src/tests/phpunit-autotest.xml
Error:         No code coverage driver is available

..................                                                18 / 18 (100%)

Time: 479 ms, Memory: 12.00 MB

OK (18 tests, 60 assertions)
+ wget https://codecov.io/bash -O codecov.sh
converted 'https://codecov.io/bash' (ANSI_X3.4-1968) -> 'https://codecov.io/bash' (UTF-8)
--2021-02-02 18:47:36--  https://codecov.io/bash
Resolving codecov.io (codecov.io)... 34.120.215.12
Connecting to codecov.io (codecov.io)|34.120.215.12|:443... connected.
HTTP request sent, awaiting response... 502 Bad Gateway
2021-02-02 18:47:36 ERROR 502: Bad Gateway.

@rullzer rullzer merged commit 9db3b28 into master Feb 2, 2021
@rullzer rullzer deleted the bugfix/noid/avoid-duplicate-template-registration branch February 2, 2021 19:37
@rullzer rullzer mentioned this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants