Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21] Fix duplicate tag info view registration #25478

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #25441

Only register the tag info view once as it's stored in a singleton.
This fixes an issue where the tag info view did not get rendered after
swiching between different file views.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@faily-bot
Copy link

faily-bot bot commented Feb 4, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1936: failure

acceptance-users

  • tests/acceptance/features/users.feature:25
Show full log
  Scenario: delete a user                                                      # /drone/src/tests/acceptance/features/users.feature:25
    Given I act as Jane                                                        # ActorContext::iActAs()
    And I am logged in as the admin                                            # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                               # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user user0                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user user0 in Users Settings could not be found
      Actions menu for user user0 in Users Settings could not be found (NoSuchElementException)
    And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Delete user" action in the user0 actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the list of users does not contains the user user0         # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()

@rullzer rullzer mentioned this pull request Feb 5, 2021
2 tasks
@PVince81
Copy link
Member

PVince81 commented Feb 5, 2021

Failing acceptance test in users page unrelated to this change.

@PVince81
Copy link
Member

PVince81 commented Feb 5, 2021

who can force merge ?

@rullzer rullzer merged commit fa6e799 into stable21 Feb 5, 2021
@rullzer rullzer deleted the backport/25441/stable21 branch February 5, 2021 10:02
@rullzer rullzer mentioned this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants