Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dav respect disallow sharing with groups #25658

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Feb 15, 2021

Replaces #25391 (didn't see it straight away 🙈) and adds tests.

Fixes #25390
Fixes nextcloud/calendar#2744

Todo

@tcitworld tcitworld added bug 3. to review Waiting for reviews php Pull requests that update Php code labels Feb 15, 2021
@tcitworld tcitworld added this to the Nextcloud 22 milestone Feb 15, 2021
@PVince81
Copy link
Member

not sure if enough as there's another PR here for ShareesAPIController with more changes: #25744

@tcitworld
Copy link
Member Author

not sure if enough as there's another PR here for ShareesAPIController with more changes: #25744

It doesn't seem to be the same though, #25744 is about respecting which groups can be shared with, and this one (and #25391) is about respecting the allow/disallow sharing with any group.

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested with Talk.
The groups are not visible in the search any more when creating a conversation.

@PVince81
Copy link
Member

build restarted

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 11, 2021
@nickvergessen
Copy link
Member

Btw your todo should be solved already with the changes here as most of the apps are using the collaboration endpoint (GroupPlugin class) or the dav principal thing which you both modified

@PVince81
Copy link
Member

Follow up Talk ticket: nextcloud/spreed#5360

I do have some small doubts: because creating a conversation is not strictly about sharing, just adding people. It just happens that Talk is using the sharing API there so is affected by this restriction.

@tcitworld
Copy link
Member Author

Btw your todo should be solved already with the changes here as most of the apps are using the collaboration endpoint (GroupPlugin class) or the dav principal thing which you both modified

Not sure what you mean, it was just about hiding "group" from placeholders like @PVince81 did with Talk.

nickvergessen and others added 2 commits May 26, 2021 11:19
Signed-off-by: Joas Schilling <coding@schilljs.com>
Closes #25390

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the dav-respect-disallow-sharing-with-groups branch from 6f43211 to 1c0d975 Compare May 26, 2021 09:20
@ChristophWurst ChristophWurst merged commit b29c3aa into master Jun 1, 2021
@ChristophWurst ChristophWurst deleted the dav-respect-disallow-sharing-with-groups branch June 1, 2021 10:07
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug php Pull requests that update Php code
Projects
None yet
5 participants