Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable basic PHP completion in Codespace #25743

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

LukasReschke
Copy link
Member

This competes with the completions provided by
https://github.com/felixfbecker/vscode-php-intellisense.

Thus disabling the completions is recommended.

Before (lots of wrong recommendations)

Screenshot 2021-02-22 at 12 30 00

After (correct recommendations)

Screenshot 2021-02-22 at 12 36 51

This competes with the completions provided by
https://github.com/felixfbecker/vscode-php-intellisense.

Thus disabling the completions is recommended.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 22, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 22 milestone Feb 22, 2021
@LukasReschke LukasReschke merged commit d090341 into master Feb 22, 2021
@LukasReschke LukasReschke deleted the disable-vs-code-intellisense branch February 22, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants