Kill jstimezonedetect from bundle #25850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
enhancement
3. to review
skjnldsv
approved these changes
Mar 1, 2021
LukasReschke
approved these changes
Mar 2, 2021
|
@rullzer Merge conflict |
rullzer
force-pushed
the
techdept/js/timezonedetect
branch
from
83926bb
to
3c83604
Compare
Taking up space while it is not needed. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Yeah I know was wating for the lodash stuff to be merged. |
|
This lead to problems like nextcloud/user_saml#543 |
danxuliu
added a commit
to nextcloud/user_saml
that referenced
this pull request
Dec 30, 2021
In Nextcloud 22 jstimezonedetect was removed from the server bundle (nextcloud/server#25850), so now each app that uses it needs to ship its own copy. For simplicity, as the app does not currently use webpack or NPM, the minified file was just added to "js/vendor". "jstz.min.js" was copied from https://github.com/pellepim/jstimezonedetect/blob/ddc9e040342d68c06129ae28011517e5b2dde664/dist/jstz.min.js (which is the same as the one included in https://registry.npmjs.org/jstimezonedetect/-/jstimezonedetect-1.0.7.tgz). jstimezonedetect is licenced under the MIT licence. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nextcloud-command
pushed a commit
to nextcloud/user_saml
that referenced
this pull request
Mar 4, 2022
In Nextcloud 22 jstimezonedetect was removed from the server bundle (nextcloud/server#25850), so now each app that uses it needs to ship its own copy. For simplicity, as the app does not currently use webpack or NPM, the minified file was just added to "js/vendor". "jstz.min.js" was copied from https://github.com/pellepim/jstimezonedetect/blob/ddc9e040342d68c06129ae28011517e5b2dde664/dist/jstz.min.js (which is the same as the one included in https://registry.npmjs.org/jstimezonedetect/-/jstimezonedetect-1.0.7.tgz). jstimezonedetect is licenced under the MIT licence. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nextcloud-command
pushed a commit
to nextcloud/user_saml
that referenced
this pull request
Apr 11, 2022
In Nextcloud 22 jstimezonedetect was removed from the server bundle (nextcloud/server#25850), so now each app that uses it needs to ship its own copy. For simplicity, as the app does not currently use webpack or NPM, the minified file was just added to "js/vendor". "jstz.min.js" was copied from https://github.com/pellepim/jstimezonedetect/blob/ddc9e040342d68c06129ae28011517e5b2dde664/dist/jstz.min.js (which is the same as the one included in https://registry.npmjs.org/jstimezonedetect/-/jstimezonedetect-1.0.7.tgz). jstimezonedetect is licenced under the MIT licence. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking up space while it is not needed.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl