Import jstz.min.js from jstimezonedetect 1.0.7 #571
Conversation
|
@danxuliu here, master serves Nextcloud 21to 24. Would the change be a problem on 21? |
In Nextcloud 21 In short, no, the change should not be a problem in Nextcloud 21 :-) |
|
Hi, any progress here? pull request is still blocked because of an "fatal: refusing to merge unrelated histories" error. Maybe a rebase would help? |
|
/rebase |
nextcloud-command
force-pushed
the
import-jstimezonedetect
branch
from
aa2d0b3
to
bcfa836
Compare
|
looks like the integration tests itself are broken. This version of Nextcloud requires at least PHP 7.4 Seams to be not related to your pull request. anyone has an idea who is able to fix and where we should report this? |
See #583 :-) |
|
/rebase |
In Nextcloud 22 jstimezonedetect was removed from the server bundle (nextcloud/server#25850), so now each app that uses it needs to ship its own copy. For simplicity, as the app does not currently use webpack or NPM, the minified file was just added to "js/vendor". "jstz.min.js" was copied from https://github.com/pellepim/jstimezonedetect/blob/ddc9e040342d68c06129ae28011517e5b2dde664/dist/jstz.min.js (which is the same as the one included in https://registry.npmjs.org/jstimezonedetect/-/jstimezonedetect-1.0.7.tgz). jstimezonedetect is licenced under the MIT licence. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nextcloud-command
force-pushed
the
import-jstimezonedetect
branch
from
bcfa836
to
7e2bcef
Compare
Fixes #543
In Nextcloud 22
jstimezonedetectwas removed from the server bundle, so now each app that uses it needs to ship its own copy. For simplicity, as the app does not currently use webpack or NPM, the minified file was just added to js/vendor.