Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug log what happens during reminders processing #28703

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

ChristophWurst
Copy link
Member

@@ -111,8 +108,9 @@ public function __construct(Backend $backend,
* @throws NotificationProvider\ProviderNotAvailableException
* @throws NotificationTypeDoesNotExistException
*/
public function processReminders():void {
public function processReminders() :void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be applied to all methods in this file 😁.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤫

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it hurts

$reminders = $this->backend->getRemindersToProcess();
$this->logger->debug(sprintf("%d reminders to process", count($reminders)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->logger->debug(sprintf("%d reminders to process", count($reminders)));
$this->logger->debug(sprintf('%d reminders to process', count($reminders)));

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you use:

Suggested change
$this->logger->debug(sprintf("%d reminders to process", count($reminders)));
$this->logger->debug('{reminders} reminders to process', ['reminders' => count($reminders)]);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I debugged the one on or company instance a bit:

			if (!is_string($calendarData)) {
				\OC::$server->getLogger()->error(
					'Debugging: ReminderService::parseCalendarData: '.
					(is_resource($reminder['calendardata'])
						? 'is_resource'
						: '!is_resource') .
					'id' . $reminder['id'] .
					'calendar_id' . $reminder['calendar_id'] .
					'object_id' . $reminder['object_id'] .
					'recurrence_id' . $reminder['recurrence_id'],
					['app' => 'dav-nickvergessen-debugging']
				);
			}

Debugging: ReminderService::parseCalendarData:
!is_resource
id 68522
calendar_id 119
object_id 0
recurrence_id 1639650600

So the reminder is not linked with any object?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind logging $reminder['is_recurring'] and $reminder['is_recurrence_exception'] as well? I feel this may be the issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_recurring true
is_recurrence_exception false

@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021
@tcitworld tcitworld added the feature: caldav Related to CalDAV internals label Dec 17, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@ChristophWurst ChristophWurst force-pushed the enhancement/caldav-reminders-logging branch from 2473433 to 7ea99d5 Compare May 23, 2022 07:26
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst merged commit ca45e6a into master Jun 2, 2022
@ChristophWurst ChristophWurst deleted the enhancement/caldav-reminders-logging branch June 2, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: caldav Related to CalDAV internals feature: dav
Projects
Development

Successfully merging this pull request may close these issues.

6 participants