Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ExternalShareActions API #28835

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 14, 2021

See example:

nextcloud/files_downloadlimit#5
https://github.com/nextcloud/files_downloadlimit/blob/32ae1dbf2df12a262f849af07ef4c4ea8f7c3cfd/src/main.js
https://github.com/nextcloud/files_downloadlimit/blob/32ae1dbf2df12a262f849af07ef4c4ea8f7c3cfd/src/models/DownloadLimitAction.js

This API is a more global way of injecting entries into the link share menu.
It can be any type currently supported by the vue components.
In opposite of the old (and now legacy deprecated) API that only allowed links (for the social app).

@skjnldsv skjnldsv requested review from a team, artonge, Pytal, szaimen and juliushaertl and removed request for a team September 14, 2021 15:46
@skjnldsv skjnldsv self-assigned this Sep 14, 2021
@skjnldsv skjnldsv added this to 📄 To do (5-20 entries) in 📁 Files team (obsolete, don't use) via automation Sep 14, 2021
@skjnldsv skjnldsv added this to the Nextcloud 23 milestone Sep 14, 2021
@skjnldsv
Copy link
Member Author

/backport to stable22

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Too bad the files_downloadlimit example does not work (yet 😁).
I'll make some real life tests by registering another component soon.

@skjnldsv

This comment has been minimized.

@szaimen

This comment has been minimized.

Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv

This comment has been minimized.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 16, 2021
@skjnldsv skjnldsv force-pushed the feat/ExternalShareActions-API branch 2 times, most recently from 5413a9e to b1572c9 Compare September 16, 2021 15:33
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: sharing high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants