Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isIE and associated legacy scripts #29966

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Remove isIE and associated legacy scripts #29966

merged 1 commit into from
Nov 30, 2021

Conversation

skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Nov 29, 2021
@skjnldsv skjnldsv self-assigned this Nov 29, 2021
@skjnldsv skjnldsv requested review from artonge, julien-nc, szaimen, nickvergessen, PVince81 and juliushaertl and removed request for a team November 29, 2021 16:06
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

IE deserves to burn in a lot of fire 🔥

Copy link

@jbmagination jbmagination left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the IE is sus 😳

(this needs to be merged ASAP, IE is a bag of trash)

@ChristophWurst
Copy link
Member

When will we drop Safar? 😈

@nickvergessen
Copy link
Member

When will we drop Safari? 😈

Safari is Chrome-based nowerdays so similar to new Edge not a problem in most cases

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 30, 2021
@skjnldsv
Copy link
Member Author

/compile amend /

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit c624c7e into master Nov 30, 2021
@skjnldsv skjnldsv deleted the feat/remove-isIE branch November 30, 2021 13:04
Pytal added a commit that referenced this pull request May 27, 2022
Removed in #29966 and partially restored in #30452

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal added a commit that referenced this pull request Jun 9, 2022
Removed in #29966 and partially restored in #30452

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11 deprecation for Nextcloud 20; support removal planned for Nextcloud 22
8 participants