Restore innocent code from IE purge #30452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
a team,
PVince81 and
szaimen
and removed request for
a team
artonge
changed the title
artonge
force-pushed
the
fix/missing_showGridView
branch
from
004fd5d
to
33692c1
Compare
CarlSchwan
approved these changes
Jan 2, 2022
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/missing_showGridView
branch
from
33692c1
to
d6337d8
Compare
|
@artonge please rebase :) |
|
/rebase |
artonge
force-pushed
the
fix/missing_showGridView
branch
from
d6337d8
to
2a0b464
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
fix/missing_showGridView
branch
from
2a0b464
to
e7026c0
Compare
szaimen
added
4. to release
|
CI failure is unrelated |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code was wrongly removed during IE purge, this PR restores it.
PR where the code was removed: code https://github.com/nextcloud/server/pull/29966/files#diff-792c35877ef47f0038761f64e662a3e778e0a6ace6ca8a8dd048e510520cd826L315
Usage of
$showGridViewin the same file: https://github.com/nextcloud/server/blob/master/core/src/OC/dialogs.js#L1032