Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize autoloader level 2 #32044

Closed
wants to merge 1 commit into from
Closed

Conversation

CarlSchwan
Copy link
Member

This is using the APCu cache approache since because we load dynamically
other apps that don't include a composer autoloader file the authoritative
class maps approach is not possible.

See
https://getcomposer.org/doc/articles/autoloader-optimization.md#optimization-level-2-b-apcu-cache

Test plan:

  1. Enable it
  2. Browse a few pages, nothing unusual happens

This is using the APCu cache approache since because we load dynamically
other apps that don't include a composer autoloader file the authoritative
class maps approach is not possible.

See
https://getcomposer.org/doc/articles/autoloader-optimization.md#optimization-level-2-b-apcu-cache

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan requested a review from a team April 21, 2022 13:04
@CarlSchwan CarlSchwan self-assigned this Apr 21, 2022
@CarlSchwan CarlSchwan requested review from PVince81, skjnldsv and come-nc and removed request for a team April 21, 2022 13:04
@kesselb
Copy link
Contributor

kesselb commented Apr 21, 2022

Please check #11290 / #11292

@CarlSchwan
Copy link
Member Author

Please check #11290 / #11292

Thanks for the links, i guess if this was a so easy fix someone else would have already done it. I will see if I can fix it otherwise I will close this Pr

@kesselb
Copy link
Contributor

kesselb commented Apr 21, 2022

Thanks for the links, i guess if this was a so easy fix someone else would have already done it.

Hmm. Also possible that everyone just forget about it ;) To invalidate the apcu cache properly some identifier is needed that changes when server and/or apps are updated.

@CarlSchwan
Copy link
Member Author

Thanks for the links, i guess if this was a so easy fix someone else would have already done it.

Hmm. Also possible that everyone just forget about it ;) To invalidate the apcu cache properly some identifier is needed that changes when server and/or apps are updated.

Alternatively we could also clear the apcu cache after an update or an app is enabled/disabled

@come-nc come-nc removed their request for review May 5, 2022 15:09
@come-nc come-nc added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 5, 2022
@CarlSchwan CarlSchwan closed this Jun 15, 2022
@skjnldsv skjnldsv deleted the performance/optimize-autoloader branch March 14, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants