Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $extraParams for setUserStatus OCP to handle extra user status attributes #32321

Closed
wants to merge 1 commit into from
Closed

Add $extraParams for setUserStatus OCP to handle extra user status attributes #32321

wants to merge 1 commit into from

Conversation

tcitworld
Copy link
Member

Allows to pass extra params to the UserStatus provider through OCP, here used to:

  • clear status after a while
  • set custom icon
  • set custom message

@tcitworld tcitworld added this to the Nextcloud 25 milestone May 10, 2022
@tcitworld tcitworld requested review from nickvergessen, CarlSchwan and a team May 10, 2022 08:28
@tcitworld tcitworld added this to In progress in Thomas things to do via automation May 10, 2022
@tcitworld tcitworld requested review from vanpertsch and come-nc and removed request for a team May 10, 2022 08:28
@tcitworld
Copy link
Member Author

Note: This will help to work with mapping statuses to calendar events in the future (we only need to check the start date of the event, not it's end).

come-nc
come-nc reviewed May 10, 2022
View reviewed changes
apps/user_status/lib/Service/StatusService.php Outdated Show resolved Hide resolved
lib/public/UserStatus/IManager.php Outdated Show resolved Hide resolved
@tcitworld tcitworld force-pushed the add-clear-add-to-user-status-public-api branch from 320ac1c to 22b4a6e Compare May 10, 2022 13:20
@tcitworld
Add $extraParams for setUserStatus OCP to handle extra user status at…
f65196c 
…tributes

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the add-clear-add-to-user-status-public-api branch from 22b4a6e to f65196c Compare May 10, 2022 13:22
@tcitworld
Copy link
Member Author

tcitworld commented May 10, 2022 •
edited
Loading

I'm not really satisfied with that so we might as well make ISettableProvider accept all parameters for setUserStatus. As there's nothing else I know of implementing it right now and all arguments are optional, it might as well be acceptable. Please tell me if you like this better.

@come-nc
Copy link
Contributor

come-nc commented May 12, 2022

I'm not really satisfied with that so we might as well make ISettableProvider accept all parameters for setUserStatus. As there's nothing else I know of implementing it right now and all arguments are optional, it might as well be acceptable. Please tell me if you like this better.

I do not have a strong opinion here, I do not know this part of the code enough. @CarlSchwan Any opinion?

Note that current code makes psalm angry as array structure accepted by implementer is more strict than interface.

@tcitworld tcitworld moved this from In progress to Pending review in Thomas things to do Jun 10, 2022
This was referenced Aug 12, 2022
Merged
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@tcitworld tcitworld added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 25, 2022
This was referenced Aug 30, 2022
Merged
Merged
@blizzz blizzz mentioned this pull request Sep 9, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@blizzz blizzz mentioned this pull request Sep 20, 2022
Closed
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv
Copy link
Member

Many conflicts 🙈

@skjnldsv skjnldsv added the stale Ticket or PR with no recent activity label Feb 27, 2024
@skjnldsv skjnldsv marked this pull request as draft February 27, 2024 17:38
nickvergessen
nickvergessen reviewed Feb 27, 2024
View reviewed changes
lib/public/UserStatus/IManager.php
@@ -53,9 +53,10 @@ public function getUserStatuses(array $userIds): array;
* @param string $messageId The id of the predefined message.
* @param string $status The status to assign
* @param bool $createBackup If true, this will store the old status so that it is possible to revert it later (e.g. after a call).
* @param array $extraParams Pass extra parameters to the user status implementation provider. Refer to the provider implementation to determine which keys are supported. Added in 25.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info needs to be added in a new @since
And it must be 29 or 30 now :P

This was referenced Mar 12, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv
Copy link
Member

skjnldsv commented May 2, 2024

Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. ☺️
Our aim is to keep the project moving forward with active collaboration. Thank you for your understanding and continued support! 🙏

@skjnldsv skjnldsv closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@come-nc come-nc come-nc left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees
No one assigned
Labels
2. developing Work in progress feature: status stale Ticket or PR with no recent activity
Projects
No open projects
Thomas things to do
  
In progress
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tcitworld @come-nc @skjnldsv @nickvergessen @CarlSchwan @blizzz