Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

29.0.0 beta 5 #44361

Merged
merged 1 commit into from
Mar 21, 2024
Merged

29.0.0 beta 5 #44361

merged 1 commit into from
Mar 21, 2024

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Mar 20, 2024 •
edited
Loading

Pending PRs:

@Altahrim
build(hub): 29.0.0 beta 5
66282de 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@ASerbinski
Copy link
Contributor

@nickvergessen @AndyScherzinger @szaimen @blizzz @kesselb or anybody else; I've had #32631 open since before NC25 and it keeps getting bumped to the next version without explanation. As far as I've been made aware, its ready to be included. When can I expect it to finally be merged?

@AndyScherzinger
Copy link
Member

@ASerbinski I'll ask @sorbaugh to coordinate efforts on getting it in, if as you say it is good to go.

@ASerbinski
Copy link
Contributor

Thank you @AndyScherzinger !

Like I said, as far as I understand, its ready. I have implemented all of the directions I've been given to that effect.

@AndyScherzinger
Copy link
Member

@ASerbinski let'S see, fingers crossed. A lot of GH actions turned red, so I restarted them, can't tell why 30+ actions failed...

@ASerbinski
Copy link
Contributor

@AndyScherzinger looks like 6 failing now, and they don't seem to be related to my PR. Stuff about sqlite and oracle, which my PR doesn't have any relation to.

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 21, 2024 •
edited
Loading

Must have PRs

Nice to have PRs

@Altahrim Altahrim added this to the Nextcloud 29 milestone Mar 21, 2024
@Altahrim Altahrim merged commit 5ca6249 into master Mar 21, 2024
169 checks passed
@Altahrim Altahrim deleted the release/29.0.0_beta_5 branch March 21, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Altahrim @ASerbinski @AndyScherzinger @ChristophWurst @nickvergessen @blizzz @skjnldsv