Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Psalm] Fix docblock for addFileFromStream #32485

Merged
merged 2 commits into from
May 31, 2022
Merged

[Psalm] Fix docblock for addFileFromStream #32485

merged 2 commits into from
May 31, 2022

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented May 18, 2022 

  <file src="lib/private/Streamer.php">
    <InvalidArgument occurrences="1">
      <code>$fh</code>
    </InvalidArgument>
  </file>

@kesselb kesselb self-assigned this May 18, 2022
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 18, 2022
@kesselb kesselb assigned kesselb and unassigned kesselb May 18, 2022
@kesselb kesselb added the 2. developing Work in progress label May 19, 2022
@kesselb kesselb removed the 2. developing Work in progress label May 20, 2022
@kesselb kesselb force-pushed the debt/noid/psalm-streamer-fh branch from ead8f2c to 56ebf9d Compare May 20, 2022 12:10
@kesselb
Fix docblock for addFileFromStream
95ec67e 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Fix type for resource
be99ea9 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the debt/noid/psalm-streamer-fh branch from 56ebf9d to be99ea9 Compare May 24, 2022 20:06
@blizzz blizzz merged commit df89e7f into master May 31, 2022
@blizzz blizzz deleted the debt/noid/psalm-streamer-fh branch May 31, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kesselb @artonge @skjnldsv @CarlSchwan @blizzz