Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various scss fixes #3260

Merged
merged 5 commits into from
Jan 30, 2017
Merged

Various scss fixes #3260

merged 5 commits into from
Jan 30, 2017

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 25, 2017 •
edited
Loading

This includes:

  1. All corners on the popover menu are now rounded [styleguide] Popover menu #2798 (comment)
  2. Colour and opacity across the popover menu are now unified
  3. #app-navigation now uses flex in column, so we don't need to use a calc to make it scrollable. All is now automatic (see mail, contacts...)
  4. Fixed blue shadow too global selector, fix Actions in sidebar has weird border #3288 & fix Remove some border-left from core styles in calendar calendar#321

@skjnldsv
Border radius fix on popover
179bd58 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix popover conflicts with app-navigation li (color & opacity)
87fd41d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 2. developing Work in progress design Design, UI, UX, etc. feature: scss labels Jan 25, 2017
@skjnldsv skjnldsv added this to the Nextcloud 12.0 milestone Jan 25, 2017
@skjnldsv skjnldsv self-assigned this Jan 25, 2017
@mention-bot
Copy link

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt to be a potential reviewer.

@skjnldsv
No more height css calc for app-navigation children
4e91759 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv mentioned this pull request Jan 25, 2017
Merged
@codecov-io
Copy link

codecov-io commented Jan 25, 2017 •
edited
Loading

Current coverage is 54.08% (diff: 100%)

No coverage report found for master at 5873a0a.

Powered by Codecov. Last update 5873a0a...07cbdbf

@skjnldsv
Blue left shadow fix #3288
9513e7a 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Blue shadow fix 2
07cbdbf 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv mentioned this pull request Jan 26, 2017
Closed
@MorrisJobke
Copy link
Member

Is this ready?

@skjnldsv
Copy link
Member Author

We can :)

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 27, 2017
MorrisJobke
MorrisJobke approved these changes Jan 27, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@skjnldsv
Copy link
Member Author

I restarted the tests.

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 29, 2017 •
edited
Loading

@jancborchardt @ChristophWurst @georgehrke
@nextcloud/designers

@skjnldsv skjnldsv requested review from blizzz and removed request for Henni and Espina2 January 29, 2017 19:33
ChristophWurst
ChristophWurst approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks good!

@ChristophWurst ChristophWurst merged commit 9a036a2 into master Jan 30, 2017
@ChristophWurst ChristophWurst deleted the various-scss-fixes branch January 30, 2017 10:34
@michag86 michag86 mentioned this pull request May 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@georgehrke georgehrke Awaiting requested review from georgehrke

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews design Design, UI, UX, etc. feature: scss
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.

Actions in sidebar has weird border Remove some border-left from core styles in calendar
5 participants
@skjnldsv @mention-bot @codecov-io @MorrisJobke @ChristophWurst