Allow to estimate free space when using object storage #33221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
tcitworld
force-pushed
the
instance-quota
branch
from
d7d6d1a
to
01742d9
Compare
|
Possible performance regression detected Show Output |
tcitworld
force-pushed
the
instance-quota
branch
from
01742d9
to
8219813
Compare
tcitworld
added
3. to review
tcitworld
requested review from
CarlSchwan,
a team,
blizzz and
skjnldsv
and removed request for
a team
|
doesn't it overlap with the |
|
|
blizzz
approved these changes
Sep 2, 2022
CarlSchwan
approved these changes
Sep 2, 2022
Merged
|
sounds like a good idea would still like to have another opinion in case of side effects @icewind1991 @juliushaertl |
Closed
icewind1991
reviewed
Jun 12, 2023
| if ($quota < 0) { | ||
| /** @var IConfig $config */ | ||
| $config = Server::get(IConfig::class); | ||
| $quota = (int) $config->getAppValue('core', 'quota_instance_global', '0'); |
There was a problem hiding this comment.
Probably makes sense to move this option under the rest of the object store options, since it is only applicable for object stores
There was a problem hiding this comment.
You mean the objectstore config.php entries? Makes sense indeed, will do.
tcitworld
force-pushed
the
instance-quota
branch
from
d69be12
to
d2a25d3
Compare
Merged
… quota If the object storage backend doesn't return quota or used bytes information, use a config override for the quota and count the size used in Nextcloud instead. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
skjnldsv
force-pushed
the
instance-quota
branch
from
d2a25d3
to
dd510df
Compare
tcitworld
added a commit
to nextcloud/app-certificate-requests
that referenced
this pull request
Feb 5, 2024
The Instance Quota app is a fork of the Group Quota app allowing to simply define a quota for the whole server instance, though keeping individual user quotas in account. It is a better way to handle things than the PR given at nextcloud/server#33221 Link to repository: https://framagit.org/framasoft/nextcloud/instance_quota Signed-off-by: Thomas Citharel <tcit@tcit.fr>
skjnldsv
added
2. developing
|
Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ObjectStorage there's no way to determine the free space for a bucket with a limited storage quota, so it's hard to detect when you have a space issue (there's nothing like
disk_free_space).It would be better if the object storage provider would provide us this information, but at least for S3 it's hard or impossible to get this information easily, so this can be an appropriate workaround in the meanwhile.
Using an AppConfig instead of a SystemConfig might be more flexible for admins to change the value, but it might also introduce a database overhead.When using the
Localstorage regulardisk_free_spaceis used instead.Still need to check if and how this affects external storages.