fix loading legacy app.php with multi app dir #33270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- requireAppFile() only appends /appinfo/app.php - without the absolute path, require_once looks into include_path - the first match in inlcude_path however migth be different from appPath - fixed by providing the tested(!), full path to the app Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
nickvergessen,
PVince81,
juliushaertl,
J0WI and
szaimen
juliushaertl
approved these changes
Jul 18, 2022
juliushaertl
added
4. to release
|
/backport to stable24 |
|
/backport to stable23 |
This was referenced Jul 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenarion: two app dirs are configured in config.php, and in both dirs is a copy of a file, with different versions. The business logic should only load from the location with the highest version.
The issue in a screenshot:
contributes to fixing #8929