Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remake website property saving with Vue #33310

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Remake website property saving with Vue #33310

merged 1 commit into from
Aug 26, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 21, 2022

Remake website property saving with Vue for accessibility purposes

Deprecation

The lookupServerUploadEnabled block

<?php if ($_['lookupServerUploadEnabled']) { ?>
<div class="verify <?php if ($_['website'] === '' || $_['websiteScope'] !== 'public') {
p('hidden');
} ?>">
<img id="verify-website" title="<?php p($_['websiteMessage']); ?>" data-status="<?php p($_['websiteVerification']) ?>" src="
<?php
switch ($_['websiteVerification']) {
case \OC\Accounts\AccountManager::VERIFICATION_IN_PROGRESS:
p(image_path('core', 'actions/verifying.svg'));
break;
case \OC\Accounts\AccountManager::VERIFIED:
p(image_path('core', 'actions/verified.svg'));
break;
default:
p(image_path('core', 'actions/verify.svg'));
}
?>" <?php if ($_['websiteVerification'] === \OC\Accounts\AccountManager::VERIFICATION_IN_PROGRESS || $_['websiteVerification'] === \OC\Accounts\AccountManager::NOT_VERIFIED) {
print_unescaped(' class="verify-action"');
} ?>>
<div class="verification-dialog popovermenu bubble menu">
<div class="verification-dialog-content">
<p class="explainVerification"></p>
<p class="verificationCode"></p>
<p><?php p($l->t('It can take up to 24 hours before the account is displayed as verified.')); ?></p>
</div>
</div>
</div>
<?php } ?>
is deprecated and therefore not brought over as it is only displayed under the condition that your website is set and the scope is public which is never the case as the public scope was deprecated in 21.0.1
/**
* Contact details visible on trusted federated servers and in the public lookup server.
*
* @deprecated 21.0.1
*/
public const VISIBILITY_PUBLIC = 'public';

@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output
1 queries added

≠ /remote.php/dav/files/test with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt

@Pytal Pytal force-pushed the enh/27869/website branch 2 times, most recently from 435fcde to a432774 Compare July 27, 2022 00:27
@Pytal Pytal force-pushed the enh/27869/website branch 3 times, most recently from c1c7cbb to 1dcbafa Compare July 28, 2022 01:00
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 28, 2022
@Pytal Pytal force-pushed the enh/27869/twitter branch 6 times, most recently from 7e0cd45 to 7fd6634 Compare July 29, 2022 20:16
This was referenced Aug 12, 2022
@blizzz blizzz mentioned this pull request Aug 24, 2022
Base automatically changed from enh/27869/twitter to master August 25, 2022 21:40
@Pytal
Copy link
Member Author

Pytal commented Aug 26, 2022

Rebased

@Pytal Pytal requested review from a team, PVince81, artonge and szaimen and removed request for a team August 26, 2022 00:41
@Pytal Pytal marked this pull request as ready for review August 26, 2022 00:41
@Pytal Pytal requested a review from CarlSchwan as a code owner August 26, 2022 00:41
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

@Pytal conflicts

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Aug 26, 2022

@Pytal conflicts

There will be many rebases

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 26, 2022
@Pytal Pytal merged commit a1fae05 into master Aug 26, 2022
@Pytal Pytal deleted the enh/27869/website branch August 26, 2022 23:25
@blizzz blizzz mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants