Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remake locale saving with Vue #33502

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Remake locale saving with Vue #33502

merged 2 commits into from
Sep 16, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 11, 2022 •
edited
Loading

See title 👆

@Pytal Pytal added this to the Nextcloud 25 milestone Aug 11, 2022
@Pytal Pytal self-assigned this Aug 11, 2022
@Pytal Pytal mentioned this pull request Aug 11, 2022
Closed
11 tasks
@Pytal Pytal force-pushed the enh/27869/locale branch 3 times, most recently from be1fab1 to 8fa575c Compare August 11, 2022 23:16
This was referenced Aug 12, 2022
Merged
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
Base automatically changed from enh/27869/twitter to master August 25, 2022 21:40
@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
@Pytal Pytal marked this pull request as ready for review September 2, 2022 20:36
@Pytal
Copy link
Member Author

Pytal commented Sep 2, 2022

Rebased

@Pytal Pytal requested review from a team, PVince81, skjnldsv and szaimen and removed request for a team September 2, 2022 20:36
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
PVince81
PVince81 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

please rebase and solve the conflicts

@Pytal
Remake locale saving with Vue
f922b2f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 16, 2022
@Pytal
Fix test failure introduced in #33819
4de19e9 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal merged commit 914714f into master Sep 16, 2022
@Pytal Pytal deleted the enh/27869/locale branch September 16, 2022 23:04
@Pytal Pytal mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: settings
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @PVince81 @CarlSchwan