-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cached getDisplayName method #33605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With @nickvergessen's suggestions
Needs a rebase after #33615 |
will be done when squashing the fixups |
bc7cd94
to
9db8fb4
Compare
The |
But |
The fallback for not having a display name is the email, yes. Which is fine in this case, that is a good way to handle not having a Display Name for the sender when it comes to emails. Added a null check on the |
d2ec3fd
to
5635308
Compare
5635308
to
f5a23e6
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
f5a23e6
to
9dd5160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
instead of the current slower
$usermanager->get($user)->getDisplayName()
Fixes #33598