Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display invalid input message #34683

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Display invalid input message #34683

merged 1 commit into from
Oct 27, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 20, 2022 •
edited
Loading

Screenshots

image
image

@Pytal Pytal added this to the Nextcloud 26 milestone Oct 20, 2022
@Pytal Pytal self-assigned this Oct 20, 2022
@CarlSchwan
Copy link
Member

Tooltips are not the proper ways to display inline errors, this should instead use error states like in the password field: https://nextcloud-vue-components.netlify.app/#/Components/NcPasswordField

But i'm not sure this is exposed to the NcTextField...

@Pytal
Copy link
Member Author

Pytal commented Oct 21, 2022

Tooltips are not the proper ways to display inline errors, this should instead use error states like in the password field: nextcloud-vue-components.netlify.app/#/Components/NcPasswordField

But i'm not sure this is exposed to the NcTextField...

Brought over the implementation from https://github.com/nextcloud/nextcloud-vue/blob/v7.0.1/src/components/NcInputField/NcInputField.vue as these fields cannot yet be fully migrated to NcTextField + updated the screenshots

@Pytal
Display invalid input message
9c54e74 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Oct 27, 2022

Rebased

@skjnldsv skjnldsv merged commit a0dea46 into master Oct 27, 2022
@skjnldsv skjnldsv deleted the enh/a11y-input-error branch October 27, 2022 10:35
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2022
@Pytal
Copy link
Member Author

Pytal commented Oct 27, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: emails feature: settings
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @CarlSchwan @artonge @skjnldsv