Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabled federated scope #34785

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix disabled federated scope #34785

merged 1 commit into from
Oct 28, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 25, 2022

With all settings in Vue let's bring this #26725 into Vue-land as well

@Pytal Pytal added this to the Nextcloud 26 milestone Oct 25, 2022
@Pytal Pytal self-assigned this Oct 25, 2022
@Pytal
Copy link
Member Author

Pytal commented Oct 25, 2022

/backport to stable25

@Pytal
Copy link
Member Author

Pytal commented Oct 27, 2022

/backport to stable25

@Pytal
Copy link
Member Author

Pytal commented Oct 27, 2022

Rebased

danxuliu
danxuliu requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the Federation app is disabled the Federated entry is disabled, but the text reads Not available as publishing user specific data to the lookup server is not allowed, contact your system administrator if you have any questions, which is not the actual reason. Should the text be fixed or the Federated entry be fully hidden (like in #26725)?

Independently of that federationEnabled is still used by personal.info.php to set data-federation-enabled. However, as it was moved from the template parameters to the initial state now it will be always set to false. Is data-federation-enabled still used anywhere? If it is that should be fixed, and if not it would be better to clean it :-)

@Pytal
Fix disabled federated scope
531bb62 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Oct 28, 2022

If the Federation app is disabled the Federated entry is disabled, but the text reads Not available as publishing user specific data to the lookup server is not allowed, contact your system administrator if you have any questions, which is not the actual reason. Should the text be fixed or the Federated entry be fully hidden (like in #26725)?

Text has been updated to Not available as federation has been disabled for your account, contact your system administrator if you have any questions

Was decided previously by @jancborchardt to show all scopes even if disabled

Independently of that federationEnabled is still used by personal.info.php to set data-federation-enabled. However, as it was moved from the template parameters to the initial state now it will be always set to false. Is data-federation-enabled still used anywhere? If it is that should be fixed, and if not it would be better to clean it :-)

Cleaned it up as it is not used anymore :)

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 28, 2022
@Pytal Pytal merged commit c723daa into master Oct 28, 2022
@Pytal Pytal deleted the fix/federated-scope branch October 28, 2022 00:52
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 28, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu requested changes

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings regression
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @artonge @CarlSchwan @danxuliu