New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable11] Fix cookie name (nc_token instead of oc_token) #3511

Merged
merged 2 commits into from Feb 16, 2017

Conversation

Projects
None yet
4 participants
@ChristophWurst
Member

ChristophWurst commented Feb 16, 2017

Backport as requested by @LukasReschke in #3362 (review).

Fix cookie name (nc_token instead of oc_token)
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 16, 2017

@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @justin-sleep to be potential reviewers.

mention-bot commented Feb 16, 2017

@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @justin-sleep to be potential reviewers.

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Feb 16, 2017

Member

@ChristophWurst You didn't adjust the unit tests 😉

Member

LukasReschke commented Feb 16, 2017

@ChristophWurst You didn't adjust the unit tests 😉

fix unit tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Feb 16, 2017

Member

@ChristophWurst You didn't adjust the unit tests 😉

Fixed 😝

Member

MorrisJobke commented Feb 16, 2017

@ChristophWurst You didn't adjust the unit tests 😉

Fixed 😝

@MorrisJobke MorrisJobke referenced this pull request Feb 16, 2017

Merged

RC2 it is #3512

@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst

ChristophWurst Feb 16, 2017

Member

@ChristophWurst You didn't adjust the unit tests 😉

I simply followed your instructions in #3362 (review)

Please prepare backport of this single change

🙊

Member

ChristophWurst commented Feb 16, 2017

@ChristophWurst You didn't adjust the unit tests 😉

I simply followed your instructions in #3362 (review)

Please prepare backport of this single change

🙊

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke
Member

LukasReschke commented Feb 16, 2017

@ChristophWurst 🤖 😜

@MorrisJobke MorrisJobke merged commit 6431f00 into stable11 Feb 16, 2017

1 of 2 checks passed

continuous-integration/drone/pr this build is pending
Details
continuous-integration/drone/push the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport-3362-stable11 branch Feb 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment