Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated node-sass #35224

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Drop deprecated node-sass #35224

merged 1 commit into from
Nov 17, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 17, 2022 •
edited
Loading

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

https://www.npmjs.com/package/node-sass

We already have sass as a direct dependency. node-sass is therefore superfluous.

@ChristophWurst
Drop deprecated node-sass
bb728ac 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst self-assigned this Nov 17, 2022
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 17, 2022
@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Nov 17, 2022
@ChristophWurst ChristophWurst marked this pull request as ready for review November 17, 2022 10:29
@juliushaertl juliushaertl merged commit 301af07 into master Nov 17, 2022
@juliushaertl juliushaertl deleted the chore/drop-deprecatd-node-sass branch November 17, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@vinicius73 vinicius73 Awaiting requested review from vinicius73

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews technical debt
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @juliushaertl @artonge