Log switching to LDAP backup host because main one is not available #35230
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
@blizzz Should that be warning? It’s an important information that main LDAP server is not reachable. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| //if LDAP server is not reachable, try the Backup (Replica!) Server | ||
| if ($isBackupHost || $isOverrideMainServer) { | ||
| $this->doConnect($this->configuration->ldapBackupHost, | ||
| $this->configuration->ldapBackupPort); | ||
| $this->configuration->ldapBackupPort); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
| @@ -681,8 +687,8 @@ | |||
| } | |||
|
|
|||
| $ldapLogin = @$this->ldap->bind($cr, | |||
| $this->configuration->ldapAgentName, | |||
| $this->configuration->ldapAgentPassword); | |||
| $this->configuration->ldapAgentName, | |||
Check notice
Code scanning / Psalm
PossiblyNullArgument
| $this->configuration->ldapAgentName, | ||
| $this->configuration->ldapAgentPassword); | ||
| $this->configuration->ldapAgentName, | ||
| $this->configuration->ldapAgentPassword); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
Ideally this is also noticed elsewhere, but upping it to Warning sounds good to me. |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
Drone failure is not related. |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
CI failure unrelated |
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
|
The backport to stable25 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com