Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate proper URL for unsupported browsers page #35302

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Generate proper URL for unsupported browsers page #35302

merged 1 commit into from
Nov 23, 2022

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 21, 2022 •
edited
Loading

Otherwise the redirect is not working properly if no htacess override is configured or if Nextcloud is installed in a subdirectory.

@juliushaertl juliushaertl requested review from skjnldsv, ChristophWurst, a team, PVince81 and artonge and removed request for a team November 21, 2022 13:39
@juliushaertl juliushaertl added bug 3. to review Waiting for reviews labels Nov 21, 2022
szaimen
szaimen approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen szaimen added this to the Nextcloud 26 milestone Nov 21, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 21, 2022

/compile

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 21, 2022
@ChristophWurst
Copy link
Member

@szaimen please consider amending the compiled assets next time. Anyone who has to bisect through the git history to find a faulty commit will be thankful.

@szaimen
Copy link
Contributor

szaimen commented Nov 21, 2022

@szaimen please consider amending the compiled assets next time. Anyone who has to bisect through the git history to find a faulty commit will be thankful.

all right. Didn't know that

@skjnldsv
Copy link
Member 

1) Test\Template\CSSResourceLocatorTest::testFindWithAppPathSymlink
229 | ArgumentCountError: Too few arguments to function OC\Template\CSSResourceLocator::__construct(), 1 passed in /drone/src/tests/lib/Template/CSSResourceLocatorTest.php on line 74 and exactly 4 expected
230 |  
231 | /drone/src/lib/private/Template/CSSResourceLocator.php:43
232 | /drone/src/tests/lib/Template/CSSResourceLocatorTest.php:74
233 | /drone/src/tests/lib/Template/CSSResourceLocatorTest.php:112
234 |  
235 | 2) Test\Template\JSResourceLocatorTest::testFindWithAppPathSymlink
236 | ArgumentCountError: Too few arguments to function OC\Template\JSResourceLocator::__construct(), 2 passed in /drone/src/tests/lib/Template/JSResourceLocatorTest.php on line 65 and exactly 5 expected
237 |  
238 | /drone/src/lib/private/Template/JSResourceLocator.php:37
239 | /drone/src/tests/lib/Template/JSResourceLocatorTest.php:65
240 | /drone/src/tests/lib/Template/JSResourceLocatorTest.php:104
241 |  

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 21, 2022
@juliushaertl
Copy link
Member Author

Whoops seems some unrelated change sneaked in, let me fix that

@juliushaertl
Generate proper URL for unsupported browsers page
61ce0ad 
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Compile assets

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 22, 2022
@szaimen szaimen merged commit 9422d80 into master Nov 23, 2022
@szaimen szaimen deleted the bugfix/noid/unsupported-url branch November 23, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@juliushaertl @szaimen @ChristophWurst @skjnldsv