Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unrelated change from #34940 #35556

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

CarlSchwan
Copy link
Member

Probably a left over from an experience that I added by mistake in the change

Probably a left over from an experience that I added by mistake in the
change

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Dec 2, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 26 milestone Dec 2, 2022
@CarlSchwan CarlSchwan requested review from nickvergessen and a team December 2, 2022 10:30
@CarlSchwan CarlSchwan self-assigned this Dec 2, 2022
@CarlSchwan CarlSchwan requested review from PVince81, icewind1991 and come-nc and removed request for a team December 2, 2022 10:30
@kesselb
Copy link
Contributor

kesselb commented Dec 2, 2022

Looks good to me 👍

I guess this was your approach to fix #34930 which I just closed as duplicate of #33187.

@kesselb kesselb mentioned this pull request Dec 2, 2022
5 tasks
@szaimen szaimen merged commit 299f979 into master Dec 3, 2022
@szaimen szaimen deleted the revert/unrelated-change branch December 3, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants