Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: migrate ocp since checker to psalm #36187

Merged
merged 1 commit into from
Jan 25, 2023
Merged

ci: migrate ocp since checker to psalm #36187

merged 1 commit into from
Jan 25, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jan 17, 2023 •
edited
Loading

  • Resolves: Unblock removal of 3rdparty nikic/php-parser

Summary

The original implementation in build/OCPSinceChecker.php did not enforce @since when a class was deprecated.

We decided to always enforce @since for classes and methods in OCP\.

TODO

  • CI
  • Review

Checklist

@kesselb kesselb added the 2. developing Work in progress label Jan 17, 2023
@kesselb kesselb self-assigned this Jan 17, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 19, 2023
View reviewed changes
lib/public/Color2.php Fixed Show fixed Hide fixed
lib/public/Color2.php Fixed Show fixed Hide fixed
lib/public/Color2.php Fixed Show fixed Hide fixed
lib/public/Color2.php Fixed Show fixed Hide fixed
lib/public/Color2.php Fixed Show fixed Hide fixed
@kesselb kesselb force-pushed the psalm-ocp-since-checker branch 2 times, most recently from e14b7fb to 5b2d863 Compare January 19, 2023 21:54
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 19, 2023
ChristophWurst
ChristophWurst approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

Could you remove the old checker right away?

build/psalm/OCPSinceChecker.php Outdated Show resolved Hide resolved
build/psalm/OCPSinceChecker.php Outdated Show resolved Hide resolved
ChristophWurst
ChristophWurst approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best PR I've seen in 2023

nickvergessen
nickvergessen approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff

@nickvergessen
Copy link
Member

However psalm fails, so might be better to rebase or whatever is needed to fix it.

@kesselb
ci: migrate ocp since checker to psalm
258c919 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@ChristophWurst
Copy link
Member

However psalm fails, so might be better to rebase or whatever is needed to fix it.

it currently fails on all PRs. yay.

@kesselb kesselb merged commit 75e8636 into master Jan 25, 2023
@kesselb kesselb deleted the psalm-ocp-since-checker branch January 25, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @nickvergessen @ChristophWurst