Add check config.php for ffmpeg_path in PreviewManager.php. fix for snap no video preview

[Jachhj-sc]

add a check in config.php for a configured movieBinary path. so now it first checks in config.php if preview_ffmpeg_path is configured. this makes it possible to install the ffmpeg binary and use it with the previewprovider and get video previews in the snap package.

So to get previews in videos with this fix.

1. adding ffmpeg binary to /var/snap/nextcloud/current/[create dir 'bin']/
2. adding the following line to config.php

'preview_ffmpeg_path' => '/var/snap/nextcloud/current/bin/ffmpeg',

3. sudo snap restart nextcloud

Signed-off-by: William william.hak57@gmail.com

• Resolves: How to install ffmpeg? nextcloud-snap/nextcloud-snap#1046

Summary

TODO

• [ ]

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[szaimen]

Hi, thanks a lot for your PR! Please add this value also to https://github.com/nextcloud/server/blob/master/config/config.sample.php. in order to document it. Thank you! :)

[tcitworld]

I'm not sure why the snap package can't just set /var/snap/nextcloud/current/bin (or whatever it looks like from inside) into the $PATH so that Nextcloud can use binaries put there straight away?

[szaimen]

I'm not sure why the snap package can't just set /var/snap/nextcloud/current/bin (or whatever it looks like from inside) into the $PATH so that Nextcloud can use binaries put there straight away?

cc @kyrofa ?

[kyrofa]

Because there's nothing useful there: the snap doesn't include ffmpeg, and it's read-only so users can't put things in its existing bin directories either. However, users CAN download static ffmpeg binaries and put them somewhere the snap can access, they just need to be able to tell Nextcloud where they are.

Could we have a writable, empty directory that we add to the PATH, just waiting for user customization? Sure, but that turns into both an attack vector and a support nightmare, and is thus not something we're interested in. Note that other apps have configs like this, seems pretty reasonable to add one more, if for no other reason than consistency.

[szaimen]

Yeah, fine to add this config value imho.

@nextcloud/server-backend WDYT?

[nickvergessen]

Config is fine, but should be documented in the sample file

[tcitworld]

In that case, instead of adding a specific config key for the ffmpeg binary (for instance, the memories app also needs ffprobe), let's add a generic extra_path config key that can be used into the OC/BinaryFinder class. Then the calls to findBinaryPath will take this new path into account.

[szaimen]

Config is fine, but should be documented in the sample file

Thanks nickvergessen! Then @Jachhj-sc please do as advised :)

[Jachhj-sc]

alright ill document it in the sample file.
shall i create a separate pull request, or link to this one for that? or what is the proper way?

[szaimen]

alright ill document it in the sample file. shall i create a separate pull request, or link to this one for that? or what is the proper way?

Please do it in this one. Thanks! :)

[Jachhj-sc]

Done added the documentation

[szaimen]

LGTM but didnt test

[szaimen]

In that case, instead of adding a specific config key for the ffmpeg binary (for instance, the memories app also needs ffprobe), let's add a generic extra_path config key that can be used into the OC/BinaryFinder class. Then the calls to findBinaryPath will take this new path into account.

Oh sorry, I overread this. Not sure about this apporach. Sounds a bit over-engineered to me...

[szaimen]

Wdyt @nickvergessen?

[nickvergessen]

yeah, also not sure about that.

[szaimen]

Okay, lets merge then as is since the memories app already has config values anyway :)

[szaimen]

CI failure unrelated

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22