-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check config.php for ffmpeg_path in PreviewManager.php. fix for snap no video preview #36225
Conversation
add a check in config.php for a configured movieBinary path. so now it first checks in config.php if preview_ffmpeg_path is configured. Signed-off-by: William <william.hak57@gmail.com>
Hi, thanks a lot for your PR! Please add this value also to https://github.com/nextcloud/server/blob/master/config/config.sample.php. in order to document it. Thank you! :) |
I'm not sure why the snap package can't just set |
cc @kyrofa ? |
Because there's nothing useful there: the snap doesn't include ffmpeg, and it's read-only so users can't put things in its existing Could we have a writable, empty directory that we add to the PATH, just waiting for user customization? Sure, but that turns into both an attack vector and a support nightmare, and is thus not something we're interested in. Note that other apps have configs like this, seems pretty reasonable to add one more, if for no other reason than consistency. |
Yeah, fine to add this config value imho. @nextcloud/server-backend WDYT? |
Config is fine, but should be documented in the sample file |
In that case, instead of adding a specific config key for the ffmpeg binary (for instance, the memories app also needs |
Thanks nickvergessen! Then @Jachhj-sc please do as advised :) |
alright ill document it in the sample file. |
Please do it in this one. Thanks! :) |
add preview_ffmpeg_path documentation. document custom path for ffmpeg so it can be used by the previewprovider to create video previews with the snap package of nextcloud. Signed-off-by: William <william.hak57@gmail.com>
add documentation preview_ffmpeg_path
Done added the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
add better description Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: William <william.hak57@gmail.com>
fix lint issue Co-authored-by: Simon L. <szaimen@e.mail.de> Signed-off-by: William <william.hak57@gmail.com>
Oh sorry, I overread this. Not sure about this apporach. Sounds a bit over-engineered to me... |
Wdyt @nickvergessen? |
yeah, also not sure about that. |
Okay, lets merge then as is since the memories app already has config values anyway :) |
CI failure unrelated |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
add a check in config.php for a configured movieBinary path. so now it first checks in config.php if preview_ffmpeg_path is configured. this makes it possible to install the ffmpeg binary and use it with the previewprovider and get video previews in the snap package.
So to get previews in videos with this fix.
Signed-off-by: William william.hak57@gmail.com
Summary
TODO
Checklist