Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] chore(CI): Opt-out of PHPUnit 10 for now #36519

Merged
merged 3 commits into from
Feb 6, 2023
Merged

[stable24] chore(CI): Opt-out of PHPUnit 10 for now #36519

merged 3 commits into from
Feb 6, 2023

Conversation

nickvergessen
Copy link
Member

Backport of #36511

@nickvergessen
chore(CI): Opt-out of PHPUnit 10 for now
4fb4fc3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Feb 3, 2023
@nickvergessen nickvergessen added this to the Nextcloud 24.0.10 milestone Feb 3, 2023
@nickvergessen nickvergessen self-assigned this Feb 3, 2023
@nickvergessen
Remove failing test that works with mocks only anyway
6761b94 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Feb 3, 2023
Merged
4 tasks
@nickvergessen
fix(CI): Fix unmockable countUsers() method
eb76fbe 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

✗ phpunit 403: rate limit exceeded

miaulalala
miaulalala approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪀

@nickvergessen nickvergessen merged commit f3cf079 into stable24 Feb 6, 2023
@nickvergessen nickvergessen deleted the backport/36511/stable24 branch February 6, 2023 10:14
@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@miaulalala miaulalala miaulalala approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 24.0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @juliushaertl @miaulalala