chore: Address review comments #37150
Draft
+72
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try { | ||
| $this->prepareUpload(dirname($sourcePath)); | ||
| $this->checkPrerequisites(); | ||
| } catch (StorageInvalidException|BadRequest|NotFound|PreconditionFailed $e) { | ||
| return true; | ||
| } | ||
| [$storage, $storagePath] = $this->getUploadStorage($this->uploadPath); | ||
| [$storage, ] = $this->getUploadStorage($this->uploadPath); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| public function prepareUpload($path): void { | ||
| $this->uploadFolder = $this->server->tree->getNodeForPath($path); | ||
| public function prepareUpload(string $path): void { | ||
| $uploadFolder = $this->server->tree->getNodeForPath($path); |
Check notice
Code scanning / Psalm
PossiblyNullPropertyFetch Note
| public function prepareUpload($path): void { | ||
| $this->uploadFolder = $this->server->tree->getNodeForPath($path); | ||
| public function prepareUpload(string $path): void { | ||
| $uploadFolder = $this->server->tree->getNodeForPath($path); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
|
Please don't forget to set the milestone when opening a PR 😃 |
juliushaertl
force-pushed
the
bugfix/cleanup-s3-multipart
branch
from
e887c55
to
be72b4c
Compare
| /** @var ICache */ | ||
| private $cache; | ||
| private ?Server $server = null; | ||
| private ?UploadFolder $uploadFolder; |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor Note
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
juliushaertl
force-pushed
the
bugfix/cleanup-s3-multipart
branch
from
be72b4c
to
43098a5
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/cleanup-s3-multipart
branch
from
43098a5
to
b3b567e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing review follow ups from #27034