Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): tab shares title and creation sort #37878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(files_sharing): tab shares title and creation sort #37878

wants to merge 1 commit into from

Conversation

2lar
Copy link

@2lar 2lar commented Apr 21, 2023 •
edited by skjnldsv
Loading

This is to fix sorting and branching.
based on issue: 36906
fix #36906

@szaimen szaimen added this to the Nextcloud 27 milestone Apr 22, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Apr 22, 2023
@szaimen szaimen requested review from artonge and Pytal April 22, 2023 16:36
@artonge
Copy link
Contributor

artonge commented Apr 24, 2023

@2lar Can you fix the linting issue first? npm run lint:fix should be enough.

This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv force-pushed the sortingfixbranch branch 2 times, most recently from 91f35cb to 2aa2822 Compare February 23, 2024 14:37
@skjnldsv skjnldsv requested review from a team and sorbaugh and removed request for a team February 23, 2024 14:38
@skjnldsv skjnldsv requested review from susnux and removed request for sorbaugh February 27, 2024 15:50
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@Altahrim
Copy link
Collaborator

@2lar Can you rebase and reword your commit using conventional commit please?
I guess you can squash in one commit

This was referenced Mar 14, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
Merged
@Altahrim
Copy link
Collaborator

Rebased with one commit instead of two

@Altahrim Altahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 26, 2024
@susnux
Copy link
Contributor

susnux commented Mar 26, 2024

/compile

@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
This was referenced Apr 4, 2024
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
@2lar @joshtrichards
fix(files_sharing): tab shares title and creation sort
1c190f6 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@joshtrichards joshtrichards changed the title Fixing the title and creation sort fix(files_sharing): tab shares title and creation sort May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Altahrim Altahrim Altahrim approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: sharing
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Sort shares by title and then creation date
7 participants
@2lar @artonge @Altahrim @susnux @skjnldsv @blizzz @szaimen