Show pending popover menu when password is enabled by default #38164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
requested review from
skjnldsv,
Pytal,
a team and
Fenn-CS
and removed request for
a team
Merged
Pytal
approved these changes
May 10, 2023
danxuliu
force-pushed
the
show-pending-popover-menu-when-password-is-enabled-by-default
branch
from
8a2e561
to
5a50a71
Compare
|
Rebased and rebuilt to solve conflicts. |
Merged
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When "Enforce password protection" is enabled in the sharing settings a popover menu is shown to set a password before the share is created. On the other hand, when "Always ask for a password" was enabled in the sharing settings and a new link share was created the share was immediately created with a default password; the user was not able to specify a password (nor create the share without password). The component template already provided the needed elements to also ask for the password without enforcing it, but the popover menu was not shown due to "enableLinkPasswordByDefault" being missing in "if" conditions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
show-pending-popover-menu-when-password-is-enabled-by-default
branch
from
5a50a71
to
9f8fa48
Compare
nickvergessen
approved these changes
May 22, 2023
|
/backport to stable27 |
|
/backport to stable26 |
nickvergessen
deleted the
show-pending-popover-menu-when-password-is-enabled-by-default
branch
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport d80f8fc,d4631921b4f4ab2832bc6698def47aa16d60c621 to stable26 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Enforce password protectionis enabled in the sharing settings a popover menu is shown to set a password before the share is created. On the other hand, whenAlways ask for a passwordwas enabled in the sharing settings and a new link share was created the share was immediately created with a default password; the user was not able to specify a password (nor create the share without password).The component template already provided the needed elements to also ask for the password without enforcing it, but the popover menu was not shown due to
enableLinkPasswordByDefaultbeing missing inifconditions.How to test
Result with this pull request
A popover menu is shown to set or remove the password of the share; a default password is pre-filled
Result without this pull request
The share is immediately created with a default password, and even if the menu of the share is opened the password can not be shown (●●●●●●●●●●●●●●● is replaced by ***************)