[stable26] Show pending popover menu when password is enabled by default #38396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
danxuliu,
nickvergessen and
Pytal
|
/compile / |
nickvergessen
approved these changes
May 23, 2023
Merged
Merged
|
/compile / |
|
conflicts |
szaimen
added
2. developing
|
@nextcloud/server-frontend could someone take this over since @danxuliu is OOTO? |
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> (cherry picked from commit d80f8fc)
When "Enforce password protection" is enabled in the sharing settings a popover menu is shown to set a password before the share is created. On the other hand, when "Always ask for a password" was enabled in the sharing settings and a new link share was created the share was immediately created with a default password; the user was not able to specify a password (nor create the share without password). The component template already provided the needed elements to also ask for the password without enforcing it, but the popover menu was not shown due to "enableLinkPasswordByDefault" being missing in "if" conditions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> (cherry picked from commit d463192)
Signed-off-by: Joas Schilling <coding@schilljs.com> (cherry picked from commit 9f8fa48)
Pytal
force-pushed
the
backport/38164/stable26
branch
from
4e3d187
to
7e48950
Compare
Pytal
approved these changes
Jun 13, 2023
Pytal
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #38164