Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(carddav): Check if SERVER variables are set before accessing them #38308

Merged
merged 1 commit into from May 23, 2023
Merged

fix(carddav): Check if SERVER variables are set before accessing them #38308

merged 1 commit into from May 23, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented May 16, 2023 •
edited by solracsf

Summary

Server variables can not be set, check if they are.

Checklist

@miaulalala miaulalala added bug 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels May 16, 2023
@miaulalala miaulalala added this to the Nextcloud 27 milestone May 16, 2023
@miaulalala miaulalala requested a review from st3iny May 16, 2023 11:11
@miaulalala miaulalala self-assigned this May 16, 2023
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2023
@szaimen szaimen enabled auto-merge May 16, 2023 13:09
@szaimen
Copy link
Contributor

szaimen commented May 16, 2023

image

@szaimen szaimen disabled auto-merge May 16, 2023 21:37
@szaimen szaimen added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels May 16, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@miaulalala
Copy link
Contributor Author

/backport to stable27

@szaimen

This comment was marked as resolved.

Sign in to view
@miaulalala @ChristophWurst
fix(carddav): Check if SERVER variables are set before accessing them
3c93ce9 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@ChristophWurst ChristophWurst force-pushed the fix/check-for-php-auth-server-variables branch from 3f19956 to 3c93ce9 Compare May 23, 2023 08:58
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels May 23, 2023
@szaimen szaimen merged commit 3894a86 into master May 23, 2023
38 checks passed
@szaimen szaimen deleted the fix/check-for-php-auth-server-variables branch May 23, 2023 12:33
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 23, 2023
Merged
@blizzz blizzz removed this from the Nextcloud 27 milestone May 23, 2023
@blizzz blizzz added this to the Nextcloud 28 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@tcitworld tcitworld tcitworld approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@miaulalala miaulalala

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: carddav Related to CardDAV internals
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: Undefined array key "PHP_AUTH_USER" at SystemAddressbook.php
6 participants
@miaulalala @szaimen @st3iny @tcitworld @ChristophWurst @blizzz