Use a11y activation util #38477
Open
Use a11y activation util #38477
+3
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <chrng8@gmail.com>
susnux
reviewed
May 26, 2023
| @@ -49,7 +49,7 @@ import $ from 'jquery' | |||
|
|
|||
| import OC from './index.js' | |||
| import OCA from '../OCA/index.js' | |||
| import { isA11yActivation } from '../Util/a11y.js' | |||
| import { isA11yActivation } from '@nextcloud/vue' | |||
There was a problem hiding this comment.
This will increase the dist bundle size by about 5MB.
Webpack is not good at tree shaking, so the best would be to use import ... from '@nextcloud/vue/dist/.../' but the a11y is currently not exported like this.
BTW: The other option to use the named import schema in every core file, is even worse...
| Before this | With this | Everything as named import |
|---|---|---|
| 57872356 | 62524760 | 73743763 |
(bytes)
There was a problem hiding this comment.
5MB seems to be a lot
There was a problem hiding this comment.
Yeah this already known (one of the reasons I am pushing ESM + vite).
But for now we need to add an entry point for this to the @nextcloud/vue library and stick with the explicit default import.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
2 tasks
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use util from
@nextcloud/vueand drop core utilChecklist