Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps)!: Upgrade symfony/event-dispatcher to supported version 5.4.26 #38546

Merged
merged 1 commit into from Aug 10, 2023
Merged

fix(deps)!: Upgrade symfony/event-dispatcher to supported version 5.4.26 #38546

merged 1 commit into from Aug 10, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 31, 2023 •
edited

Summary

TODO

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 28 milestone May 31, 2023
@nickvergessen nickvergessen self-assigned this May 31, 2023
@nickvergessen nickvergessen marked this pull request as draft May 31, 2023 12:28
@nickvergessen nickvergessen mentioned this pull request May 31, 2023
Merged
@nickvergessen nickvergessen changed the title Techdebt/noid/upgrade symfony/event dispatcher fix(deps): Upgrade symfony/event-dispatcher to supported version 5.4.22 May 31, 2023
@nickvergessen nickvergessen changed the title fix(deps): Upgrade symfony/event-dispatcher to supported version 5.4.22 fix(deps)!: Upgrade symfony/event-dispatcher to supported version 5.4.22 Jun 2, 2023
@nickvergessen nickvergessen force-pushed the techdebt/noid/upgrade-symfony/event-dispatcher branch from a408dcf to 01f4507 Compare June 2, 2023 07:58
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 2, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 2, 2023
View reviewed changes
apps/workflowengine/lib/Manager.php Fixed Show fixed Hide fixed
apps/workflowengine/lib/Manager.php Fixed Show fixed Hide fixed
apps/workflowengine/lib/Manager.php Fixed Show fixed Hide fixed
@nickvergessen nickvergessen force-pushed the techdebt/noid/upgrade-symfony/event-dispatcher branch from 5e598e1 to d4f4997 Compare June 2, 2023 10:51
@nickvergessen nickvergessen force-pushed the techdebt/noid/upgrade-symfony/event-dispatcher branch from d4f4997 to 5befe72 Compare June 23, 2023 07:13
@nickvergessen
Copy link
Member Author

There are hundreds of psalm errors now because our legacy SymfonyAdapter claims to be a Symfony\Component\EventDispatcher\EventDispatcherInterface and it's typed in all kind of places like that, but at the same time the order change Symfony announced.

I see 2 ways forward at the moment:

  1. Swap the order of the event and eventName everywhere and continue
    • breaks only emitting code, so apps are only affected when they create events, not when they listen to events
  2. move to typed events
    • breaks listening apps too

@nickvergessen nickvergessen force-pushed the techdebt/noid/upgrade-symfony/event-dispatcher branch from 5befe72 to 10fdcfa Compare June 23, 2023 08:40
@ChristophWurst
Copy link
Member

here are hundreds of psalm errors now because our legacy SymfonyAdapter claims to be a Symfony\Component\EventDispatcher\EventDispatcherInterface and it's typed in all kind of places like that, but at the same time the order change Symfony announced.

Deprecated in 20 and was never a public API. I'm fine dropping it and only maintaining the OCP dispatcher with 28+

Ref #21848

This was referenced Jun 30, 2023
Merged
Merged
Merged
This was referenced Jul 11, 2023
Merged
Merged
This was referenced Jul 19, 2023
Merged
Merged
Merged
This was referenced Jul 27, 2023
Merged
Merged
@nickvergessen nickvergessen force-pushed the techdebt/noid/upgrade-symfony/event-dispatcher branch from 10fdcfa to d35fe04 Compare July 28, 2023 08:54
@nickvergessen nickvergessen mentioned this pull request Jul 28, 2023
Merged
@nickvergessen nickvergessen force-pushed the techdebt/noid/upgrade-symfony/event-dispatcher branch from d35fe04 to 9511c81 Compare July 28, 2023 15:11
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 28, 2023
View reviewed changes
apps/files_external/lib/Service/BackendService.php Outdated
@@ -112,7 +113,7 @@
private function callForRegistrations() {
static $eventSent = false;
if (!$eventSent) {
\OC::$server->getEventDispatcher()->dispatch(
\OC::$server->get(IEventDispatcher::class)->dispatch(

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\EventDispatcher\IEventDispatcher::dispatch has been marked as deprecated
@nickvergessen nickvergessen mentioned this pull request Jul 28, 2023
Merged
4 tasks
@nickvergessen nickvergessen changed the title fix(deps)!: Upgrade symfony/event-dispatcher to supported version 5.4.22 fix(deps)!: Upgrade symfony/event-dispatcher to supported version 5.4.26 Aug 4, 2023
@nickvergessen nickvergessen force-pushed the techdebt/noid/upgrade-symfony/event-dispatcher branch from 9511c81 to 327e37a Compare August 4, 2023 09:49
@nickvergessen nickvergessen marked this pull request as ready for review August 4, 2023 09:50
ChristophWurst
ChristophWurst approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

kesselb
kesselb approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@juliushaertl juliushaertl mentioned this pull request Aug 7, 2023
Merged
4 tasks
@nickvergessen
fix(deps)!: Upgrade symfony/event-dispatcher to supported version 5.4.26
63b6fb7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Rebasing to see if the failing acceptance tests are linked or temporary

@nickvergessen nickvergessen force-pushed the techdebt/noid/upgrade-symfony/event-dispatcher branch from 327e37a to 63b6fb7 Compare August 10, 2023 07:36
@nickvergessen nickvergessen merged commit 9533dcf into master Aug 10, 2023
36 of 37 checks passed
@nickvergessen nickvergessen deleted the techdebt/noid/upgrade-symfony/event-dispatcher branch August 10, 2023 09:48
@nickvergessen nickvergessen mentioned this pull request Oct 26, 2023
Merged
@Orchal Orchal mentioned this pull request Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Altahrim Altahrim Altahrim approved these changes

@kesselb kesselb kesselb approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nickvergessen @ChristophWurst @AndyScherzinger @Altahrim @kesselb